Skip to content

Removing LegacyPropertyManagementTrait from Changelog class #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removing LegacyPropertyManagementTrait from Changelog class #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions migrations/54-60/removed-backward-incompatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,7 @@ if ($app instanceof \Joomla\CMS\Application\ConsoleApplication) {
- `\Joomla\CMS\MVC\Controller\ApiController` uses a `Registry` object for the model state.
- `\Joomla\CMS\User\UserHelper::getProfile()` returns a `stdClass` object now.

### `Joomla\CMS\Changelog\Changelog` has been changed significantly

- PR: https://github.com/joomla/joomla-cms/pull/44897
- Description: The `Changelog` class was entirely depending on the `LegacyPropertyManagementTrait` and its `->get()` method. This is problematic because the `->get()` method circumvents the complete access protection in PHP and the trait itself is deprecated. In Joomla 6.0 the properties of the class have been mostly changed to public and can be accessed directly and the trait has been removed.