Skip to content

fix: Fixed provenance card alignment #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: Fixed provenance card alignment #1068

wants to merge 8 commits into from
+27 −26

Conversation

EGAMAGZ
Copy link
Contributor

@EGAMAGZ EGAMAGZ commented Apr 24, 2025

Fixes #1067

imagen

@AugustinMauroy
Copy link
Contributor

Have you the ability to fix this behaviour ?
image

@EGAMAGZ EGAMAGZ marked this pull request as draft April 24, 2025 18:02
@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Apr 24, 2025

WIP

@AugustinMauroy
Copy link
Contributor

Thanks !
FYI the sreenshot as been took with an iPhone 14

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Apr 24, 2025 •
edited
Loading

On different device sizes will look like this:

imagen

imagen

@EGAMAGZ EGAMAGZ marked this pull request as ready for review April 24, 2025 18:17
AugustinMauroy
AugustinMauroy approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@crowlKats
Copy link
Collaborator

crowlKats commented Apr 25, 2025 •
edited
Loading

i feel like the phone ones could do with some more love; maybe reduce fontsize of GitHub Actions to make it and the link all fit on the same line?

@EGAMAGZ
Copy link
Contributor Author

EGAMAGZ commented Apr 25, 2025

Added more love as requested 🤣

imagen

imagen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provenance card is ugly
3 participants
@EGAMAGZ @AugustinMauroy @crowlKats