Fix conic error #284
Open
Fix conic error #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrosemberg
commented
Apr 12, 2025
Comment on lines
+136
to
+138
| # FIXME: this is not working - https://github.com/jump-dev/DiffOpt.jl/issues/283 | ||
| # @test JuMP.coefficient(MOI.get(model, DiffOpt.ReverseConstraintFunction(), csoc).func.func.func, t.index) ≈ ds atol=ATOL rtol=RTOL | ||
|
|
There was a problem hiding this comment.
No clear API: #283
andrewrosemberg
commented
Apr 12, 2025
| end | ||
| #FIXME: this test is not working - https://github.com/jump-dev/DiffOpt.jl/issues/285 | ||
| # Besides API errors, Reverse and Forward differentiation are not matching | ||
| # function test_differentiating_conic_with_PSD_and_POS_constraints() |
There was a problem hiding this comment.
Issues:
- Missing Bridge: Error
DiffOpt.forward_differentiate!from PSD Conic JuMP problems #285 - Can't call
JuMP.valueafter differentiate - Foward does not match backward in this PSD case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jg/jumpapi #284 +/- ##
==============================================
+ Coverage 89.10% 89.30% +0.20%
==============================================
Files 16 16
Lines 1992 1992
==============================================
+ Hits 1775 1779 +4
+ Misses 217 213 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug in the conic formulation in which forward sensitivities with LHS have flipped the sign.
Related to how the
dAmatrix of sensitivities is used.TODO:
ReverseConstraintFunctionfor Conic Constraints #283DiffOpt.forward_differentiate!from PSD Conic JuMP problems #285