-
Notifications
You must be signed in to change notification settings - Fork 4
add MOI to LP conversion #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 87.25% // Head: 88.94% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 87.25% 88.94% +1.68%
==========================================
Files 5 6 +1
Lines 361 416 +55
==========================================
+ Hits 315 370 +55
Misses 46 46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
related to jump-dev/MathOptInterface.jl#1940 @odow, we should only support MOI to a single LP form. The other conversions should follow from that point. @blegat, currently the conic geometric form is very flexible here. a change to MatrixOfConstraints would limit the available sets to a fixed subset, right? Have you thought about that? |
I think MatrixOptInterface should do the matrix conversion to MOI both ways. after this, MatOI will be able to do it will be missing: |
for (src_ci, cache_ci) in src_to_cache.con_map | ||
index_map[src_ci] = cache_to_dest[cache_ci] | ||
end | ||
return index_map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just return src_to_cache
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense!
We can move https://github.com/jump-dev/DiffOpt.jl/blob/master/src/product_of_sets.jl to this repo and use it for the conic version. |
No description provided.