[Fix] Add plural naming formats in scaffolding #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked by #17 |
varshaprasad96
changed the title
ncdc
suggested changes
Jun 7, 2022
varshaprasad96
force-pushed
the
add-naming-formats
branch
from
29480ff to
d06ba9c
Compare
|
Rebased this with master. Not sure why CI isn't getting triggered. Closing and reopening the PR. |
|
@varshaprasad96 looks like you still need to rebase - perhaps your local copy of |
varshaprasad96
force-pushed
the
add-naming-formats
branch
from
d06ba9c to
bfd96c8
Compare
Signed-off-by: varshaprasad96 <[email protected]>
varshaprasad96
force-pushed
the
add-naming-formats
branch
from
bfd96c8 to
0e874b8
Compare
ncdc
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds plural formats while defining interfaces which is similar to what code-gen does.
This is blocked on #17 and needs to be rebased after it is merged. Please review only the last 2 commits.
It is ready for review, but blocked for merging hence converting it to draft.
Fixes: #19