Added support for Ellipse, Polygon and SetPixel #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
July 22, 2019 13:37
…sposal. Added Ellipse and Polygon methods. Changed Rectangle method to also call FillRect Updated color management to take as input VBScript compatible color (first and third byte flipped when RGB is encoded)
…he component are treated as VBScript compatible RGB colors (first and third bytes are flipped)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not with the intention of merging as-is (it also has binaries) but in case you are interested to look and take some of the additions.
It adds support for Ellipse, Polygon and SetPixel.
I reviewed also memory management for disposable objects and refactored a code a bit using using() clause.
You will notice also semantics changed for Rectangle. From prior usage of AspImage we noticed that Rectangle will also fill the image using BackgroundColor property.
With Ellipse I did the same. With Polygon forced the concept of EndPath and Fill the background for simplicity. In theory the behavior should not be like that, but could not find good documentation on how it should work.
Also notice that input/output of color was adapted to VBScript which reverses RGB colors and apparently AspImage uses that mode internally? At least that's how it worked for us, so I added a few routines to reverse the R and B parts for all input and output from the component, so internally the backing field is used when dealing with colors.