Skip to content

Patching log4j version to v2.15.0 #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Patching log4j version to v2.15.0 #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
BrowserMob Proxy allows you to manipulate HTTP requests and responses, capture HTTP content, and export performance data as a [HAR file](http://www.softwareishard.com/blog/har-12-spec/).
BMP works well as a standalone proxy server, but it is especially useful when embedded in Selenium tests.

The latest version of BrowserMob Proxy is 2.1.5, powered by [LittleProxy](https://github.com/adamfisk/LittleProxy).
The latest version of BrowserMob Proxy is 2.1.6, powered by [LittleProxy](https://github.com/adamfisk/LittleProxy).

If you're running BrowserMob Proxy within a Java application or Selenium test, get started with [Embedded Mode](#getting-started-embedded-mode). If you want to run BMP from the
command line as a standalone proxy, start with [Standalone](#getting-started-standalone).
Expand All @@ -14,7 +14,7 @@ To use BrowserMob Proxy in your tests or application, add the `browsermob-core`
<dependency>
<groupId>net.lightbody.bmp</groupId>
<artifactId>browsermob-core</artifactId>
<version>2.1.5</version>
<version>2.1.6</version>
<scope>test</scope>
</dependency>
```
Expand Down Expand Up @@ -74,7 +74,7 @@ The legacy interface, implicitly defined by the ProxyServer class, has been extr
proxyServer.start();
// [...]

// To use the LittleProxy-powered 2.1.5 release, simply change to
// To use the LittleProxy-powered 2.1.6 release, simply change to
// the LegacyProxyServer interface and the adapter for the new
// LittleProxy-based implementation:
LegacyProxyServer proxyServer = new BrowserMobProxyServerLegacyAdapter();
Expand Down Expand Up @@ -205,7 +205,7 @@ If you're using Java and Selenium, the easiest way to get started is to embed th
<dependency>
<groupId>net.lightbody.bmp</groupId>
<artifactId>browsermob-core</artifactId>
<version>2.1.5</version>
<version>2.1.6</version>
<scope>test</scope>
</dependency>
```
Expand Down Expand Up @@ -388,7 +388,7 @@ You'll need maven (`brew install maven` if you're on OS X):

[~]$ mvn -DskipTests

You'll find the standalone BrowserMob Proxy distributable zip at `browsermob-dist/target/browsermob-proxy-2.1.5-SNAPSHOT-bin.zip`. Unzip the contents and run the `browsermob-proxy` or `browsermob-proxy.bat` files in the `bin` directory.
You'll find the standalone BrowserMob Proxy distributable zip at `browsermob-dist/target/browsermob-proxy-2.1.6-SNAPSHOT-bin.zip`. Unzip the contents and run the `browsermob-proxy` or `browsermob-proxy.bat` files in the `bin` directory.

When you build the latest code from source, you'll have access to the latest snapshot release. To use the SNAPSHOT version in your code, modify the version in your pom:
```xml
Expand Down
4 changes: 2 additions & 2 deletions browsermob-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<artifactId>browsermob-proxy</artifactId>
<groupId>net.lightbody.bmp</groupId>
<version>2.1.6-SNAPSHOT</version>
<version>2.1.6</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down Expand Up @@ -246,4 +246,4 @@
<scope>test</scope>
</dependency>
</dependencies>
</project>
</project>
4 changes: 2 additions & 2 deletions browsermob-dist/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<parent>
<artifactId>browsermob-proxy</artifactId>
<groupId>net.lightbody.bmp</groupId>
<version>2.1.6-SNAPSHOT</version>
<version>2.1.6</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down Expand Up @@ -147,4 +147,4 @@
</plugin>
</plugins>
</build>
</project>
</project>
4 changes: 2 additions & 2 deletions browsermob-legacy/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<artifactId>browsermob-proxy</artifactId>
<groupId>net.lightbody.bmp</groupId>
<version>2.1.6-SNAPSHOT</version>
<version>2.1.6</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down Expand Up @@ -152,4 +152,4 @@
</profile>
</profiles>

</project>
</project>
4 changes: 2 additions & 2 deletions browsermob-rest/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<artifactId>browsermob-proxy</artifactId>
<groupId>net.lightbody.bmp</groupId>
<version>2.1.6-SNAPSHOT</version>
<version>2.1.6</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down Expand Up @@ -173,4 +173,4 @@

</dependencies>

</project>
</project>
4 changes: 2 additions & 2 deletions mitm/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<parent>
<artifactId>browsermob-proxy</artifactId>
<groupId>net.lightbody.bmp</groupId>
<version>2.1.6-SNAPSHOT</version>
<version>2.1.6</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down Expand Up @@ -112,4 +112,4 @@

</dependencies>

</project>
</project>
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>net.lightbody.bmp</groupId>
<artifactId>browsermob-proxy</artifactId>
<version>2.1.6-SNAPSHOT</version>
<version>2.1.6</version>
<modules>
<module>browsermob-core</module>
<module>browsermob-legacy</module>
Expand Down Expand Up @@ -68,7 +68,7 @@

<maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>

<log4j.version>2.9.0</log4j.version>
<log4j.version>2.15.0</log4j.version>
Copy link

@twsheehan twsheehan Dec 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @vidhem suggests; can we bump up to version 2.17.0 for the reason described:

The Log4j team has been made aware of a security vulnerability, CVE-2021-45105, that has been addressed in Log4j 2.17.0 for Java 8 and up.

I tested your patch locally @YLcoding with both versions 2.15.0 and 2.17.0 with both versions, all unit tests pass except for: net.lightbody.bmp.proxy.BindAddressTest.testClientBindAddressCannotConnect

java.lang.AssertionError: Expected exception: org.apache.http.conn.HttpHostConnectException

Evaluating localHostAddr = InetAddress.getLocalHost() does allow the HTTP client to connect to the proxy and I do not observe the expected UnknownHostException.


<groovy.version>2.4.12</groovy.version>
<groovy-eclipse-batch.version>2.4.3-01</groovy-eclipse-batch.version>
Expand Down