Add license checking to lint #3449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously these were only tested in GitHub Actions. Add the same checks to "make lint", to match "Lints". Signed-off-by: Anders F Björklund <[email protected]>
jandubois
reviewed
Apr 20, 2025
Makefile
Outdated
| @@ -467,13 +467,17 @@ check-generated: | |||
| ((git diff $$(find . -name '*.pb.desc') | cat) && \ | |||
| (echo "Please run 'make generate' when making changes to proto files and check-in the generated file changes" && false)) | |||
|
|
|||
| LICENSES = Apache-2.0,BSD-2-Clause,BSD-2-Clause-FreeBSD,BSD-3-Clause,MIT,ISC,Python-2.0,PostgreSQL,X11,Zlib | |||
There was a problem hiding this comment.
I don't like that we list allowed licenses in 2 places. The other place is:
lima/.github/workflows/test.yml
Line 68 in 56702e0
Can't we just put that line into a textfile and use it like this:
go-licenses check … --allowed-licenses="$(cat allowed-licenses.txt)"
There was a problem hiding this comment.
Probably GHA should just run make lint ?
There was a problem hiding this comment.
The only thing is how to install the tools
Signed-off-by: Anders F Björklund <[email protected]>
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these were only tested in GitHub Actions.
Since PR #3293
Add the same checks to "make lint", to match "Lints".
Closes #3443