Skip to content

config: allow asking for input even in an empty workspace #246927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

connor4312
Copy link
Member

This behavior dates from when inputs were first added (#63910). I don't
think this does much anymore -- if a config is not found in the
requested section, undefined is returned anyway, and aborting
early doesn't get us much.

Fixes #245707

This behavior dates from when inputs were first added (#63910). I don't
think this does much anymore -- if a config is not found in the
requested section, undefined is returned anyway, and aborting
early doesn't get us much.

Fixes #245707
@connor4312 connor4312 self-assigned this Apr 18, 2025
@connor4312 connor4312 enabled auto-merge (squash) April 18, 2025 21:32
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 18, 2025
bhavyaus
bhavyaus previously approved these changes Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error starting github: CodeExpectedError: Variable 'github_token'
2 participants