Skip to content

Ldblib #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2022
Merged

Ldblib #39

merged 5 commits into from
Sep 20, 2022

Conversation

ankitpokhrel
Copy link
Collaborator

Relates to #27

@ankitpokhrel
Ldblib
2c6bf9b 
Relates to #27
bobtfish
bobtfish reviewed Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@bobtfish bobtfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks great!

A bit more cleanup of the over-abundant types would be nice for readability if you have time.

@ankitpokhrel ankitpokhrel merged commit a715a01 into main Sep 20, 2022
@ankitpokhrel ankitpokhrel deleted the ldblib branch September 20, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobtfish bobtfish bobtfish left review comments

@khvzak khvzak Awaiting requested review from khvzak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankitpokhrel @bobtfish