chore(NODE-6939): update typescript to 5.8.3 #4526
Conversation
baileympearson
added
the
Primary Review
package-lock.json
Outdated
| @@ -60,7 +60,7 @@ | |||
| "source-map-support": "^0.5.21", | |||
| "ts-node": "^10.9.2", | |||
| "tsd": "^0.31.2", | |||
There was a problem hiding this comment.
The AC says to update tsd as well
There was a problem hiding this comment.
Updated and issues fixed. I needed to remove some tests from the slow model tests (since we cannot use namespaced types anymore) but don't think that impacts what that was actually testing.
durran
force-pushed
the
NODE-6939
branch
2 times, most recently
from
d7b78f0 to
beb0929
Compare
| }, | ||
|
|
||
| [Symbol.asyncDispose]: function (): PromiseLike<void> { | ||
| return closeHandler().then(() => undefined); |
There was a problem hiding this comment.
| return closeHandler().then(() => undefined); | |
| async [Symbol.asyncDispose]() { | |
| await closeHandler(); |
a suggestion: nothing wrong with async syntax here I think, just a bit simpler to drop the return value.
There was a problem hiding this comment.
Also probably worth leaving a comment about how this shouldn't be used (I don't think it will but in case).
On older Node versions this is going to be:
{
throw() {/*...*/} // ...
async undefined() {
}
}But typescript isn't going to let you know, ideally a test would fail on node 16 but might as well leave a paper trail.
| @@ -730,10 +731,19 @@ const COMPRESSION_DETAILS_SIZE = 9; // originalOpcode + uncompressedSize, compre | |||
| * An OP_COMPRESSED request wraps either an OP_QUERY or OP_MSG message. | |||
| */ | |||
| export class OpCompressedRequest { | |||
| private command: WriteProtocolMessageType; | |||
| private options: { zLibCompressionLevel: number; agreedCompressor: CompressorName }; | |||
There was a problem hiding this comment.
| private options: { zLibCompressionLevel: number; agreedCompressor: CompressorName }; | |
| private options: { zlibCompressionLevel: number; agreedCompressor: CompressorName }; |
| ) { | ||
| this.command = command; | ||
| this.options = { | ||
| zLibCompressionLevel: options.zlibCompressionLevel, |
There was a problem hiding this comment.
| zLibCompressionLevel: options.zlibCompressionLevel, | |
| zlibCompressionLevel: options.zlibCompressionLevel, |
There was a problem hiding this comment.
should there be some sort of test that catches this?
| agreedCompressor: this.options.agreedCompressor | ||
| }, | ||
| messageToBeCompressed | ||
| ); |
There was a problem hiding this comment.
| ); | |
| const compressedMessage = await compress(this.options, messageToBeCompressed); |
Description
Updates typescript to 5.8.3
What is changing?
erasableSyntaxOnlyoption.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6939
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript