Skip to content

Vs/refactoring2 #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
May 6, 2025
Merged

Vs/refactoring2 #563

merged 34 commits into from
May 6, 2025

Conversation

vsangereanMOZ
Copy link
Collaborator

@vsangereanMOZ vsangereanMOZ commented Apr 30, 2025

Relevant Links

Bugzilla: 1953253

Description of Code / Doc Changes

  • Extracted repeated sequences in Example Page POM
  • Replaced hardcoded values like the URLs, ping validations and search terms with module-level constants for clarity and maintainability
  • Improved variable and test names for better clarity and intent
  • Reformatted long expressions and docstrings for consistency
  • Switched from raw sleeps to functional waits where possible

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): Example page
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-04-30T14:24:51.967Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T06:37:33.610Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T06:37:40.491Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T06:37:46.377Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg/ODyATp9kQTGUXC7InQRGbw",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/UzqSq8FSRc25cwb_PdvnCg"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T06:37:57.876Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/SmGZQUhgToKOF0YwZp3A-w/OlfG5HHDTJuSyybojxMsSQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/SmGZQUhgToKOF0YwZp3A-w"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/SmGZQUhgToKOF0YwZp3A-w/OlfG5HHDTJuSyybojxMsSQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/SmGZQUhgToKOF0YwZp3A-w"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T11:07:35.152Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T14:10:29.916Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T14:10:31.511Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T14:10:35.068Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T14:11:36.987Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T14:15:26.137Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T14:26:19.847Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T14:58:53.190Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-05T14:58:56.320Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-06T06:45:21.501Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-06T06:53:50.667Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-06T07:27:08.284Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-06T08:52:01.023Z

Copy link

Uh oh! Looks like an error!

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

This request requires the client to satisfy the following scope expression:

{
  "AnyOf": [
    "queue:rerun-task:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ/fhxZWi4tRrKgN6oygaMcmQ",
    "queue:rerun-task-in-project:none",
    {
      "AllOf": [
        "queue:rerun-task",
        "assume:scheduler-id:mozilla-level-1/PerxLs36SySVx7yjyV-xSQ"
      ]
    }
  ]
}

  • method: rerunTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2025-05-06T08:52:31.032Z

Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! Looks good Virgil.

@vsangereanMOZ vsangereanMOZ merged commit 3f5e6ac into main May 6, 2025
7 of 9 checks passed
@vsangereanMOZ vsangereanMOZ deleted the vs/Refactoring2 branch May 6, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants