-
Notifications
You must be signed in to change notification settings - Fork 83
feature, NGINX One: Add release note for certs on CSGs #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
@sylwang I've proposed fixes for 2 of your 3 comments, and responded to the other. Let me know :) |
Co-authored-by: Sylvia Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Miniscule LOGAF on my edit suggestions: also feels weird seeing the product name with an article ("the") beforehand, but that's probably a me thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add to Alan's comments
Co-authored-by: Alan Dooley <[email protected]>
Proposed changes
Based mostly on https://github.com/nginx/documentation/pull/34/files
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
Footnotes
Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩