Skip to content

feature, NGINX One: Add release note for certs on CSGs #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 14, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Feb 25, 2025

Proposed changes

Based mostly on https://github.com/nginx/documentation/pull/34/files

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@mjang mjang self-assigned this Feb 25, 2025
@mjang mjang requested a review from sylwang February 25, 2025 19:45
@mjang mjang marked this pull request as ready for review February 25, 2025 19:46
@mjang mjang requested a review from a team as a code owner February 25, 2025 19:46
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/230/

@mjang
Copy link
Contributor Author

mjang commented Feb 26, 2025

@sylwang I've proposed fixes for 2 of your 3 comments, and responded to the other. Let me know :)

@mjang mjang requested a review from sylwang February 26, 2025 21:55
@JTorreG JTorreG added the product/nginx-one NGINX One Console label Mar 4, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 14, 2025
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Miniscule LOGAF on my edit suggestions: also feels weird seeing the product name with an article ("the") beforehand, but that's probably a me thing.

Copy link
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add to Alan's comments

@mjang mjang merged commit 82045bb into main Mar 14, 2025
9 checks passed
@mjang mjang deleted the feature-mjang-cert-csg-changelog branch March 14, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants