Handle-none-outputs #790
Open
Handle-none-outputs #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 88.51% 88.67% +0.15%
==========================================
Files 83 83
Lines 17719 17751 +32
Branches 3441 3451 +10
==========================================
+ Hits 15684 15740 +56
+ Misses 1665 1642 -23
+ Partials 370 369 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tclose
force-pushed
the
handle-none-outputs
branch
from
4e5d4ab to
7aaa539
Compare
…uts are set to be empty
tclose
force-pushed
the
handle-none-outputs
branch
from
7aaa539 to
aa35926
Compare
effigies
approved these changes
Apr 18, 2025
Comment on lines
+186
to
189
| if inputs is not None: | ||
| if not isinstance(inputs, dict): | ||
| raise ValueError( | ||
| f"Input names ({inputs}) should not be provided when " |
There was a problem hiding this comment.
Just looking at this, it seems like inputs could be a list[str | Arg], but it isn't turned into a dict before this. This means we'll now error on an empty list as well as a populated list, but maybe we should just remove the list annotation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
Handles the case of tasks and workflows without any outputs (i.e. return type is set to None). In this case the outputs are empty.
Checklist