-
Notifications
You must be signed in to change notification settings - Fork 82
[RFC] Support for air gapped mode #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This will benefit network limited users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an RFC to support air-gapped environments for OPEA microservices by outlining the online data types and proposing verification methods.
- Adds a new RFC document outlining air-gap support for microservices.
- Details different online data types and proposed handling methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Awaiting AMD comments.
PS, fixed grammar only because copilot was engaged, wanted to see what it missed!
Fixed all grammar typo |
Have we captured that the tool we build should be executable by the application owner/deployer to ensure OPEA is not violating any re-distribution constraints/license agreements. The tool like our other scripts should take arguments or environment variable, a union of all the environment variables across the application pipeline like HuggingFace token, access token to private container and data repositories etc. |
@mkbhanda Models can be downloaded from HF only if owner of given HF token has accepted their licenses. In general licenses also require that license is included when data is re-distributed, but license info seems to be included only with a subset of models used by OPEA (maybe other models are not downloaded from HF, and/or are public domain?):
|
9988aab
to
67a016c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but consider the remaining 4 suggestions.
Signed-off-by: Lianhao Lu <[email protected]> Co-authored-by: Eero Tamminen <[email protected]>
67a016c
to
e268bc0
Compare
Related to opea-project/GenAIComps#1480, opea-project/GenAIExamples#1405