-
Notifications
You must be signed in to change notification settings - Fork 224
8328864: NullPointerException in sun.security.jca.ProviderList.getService() #3442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport. Updated Risk: Low. Tip change was merged in May 2024 and adds conditional statement to catch exception case, otherwise preserving functionality. Further, new test explicitly confirms altered functionality. Testing:
|
@satyenme This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Backporting JDK-8328864: NullPointerException in sun.security.jca.ProviderList.getService(). Updated
getService
to check whethergetProvider
returns null when checking for preferred providers, continuing the loop if so. Added NullPreferredList test. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3442/head:pull/3442
$ git checkout pull/3442
Update a local copy of the PR:
$ git checkout pull/3442
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3442/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3442
View PR using the GUI difftool:
$ git pr show -t 3442
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3442.diff
Using Webrev
Link to Webrev Comment