ENH: Enabling parsing ulonglong from json

[deponovo]

• closes read_json: ValueError: Value is too big #26068
• tests added / passed
• Ensure all linting tests pass, see here for how to run them
• whatsnew entry

[pep8speaks]

Hello @deponovo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-12-10 12:01:29 UTC

[jbrockmendel]

cc @WillAyd

[WillAyd]

I think ujson added this upstream. See

ultrajson/ultrajson@6430079

@deponovo I think better to just copy what they've already done down rather than have a new implementation

[deponovo]

I think ujson added this upstream. See

ultrajson/ultrajson@6430079

@deponovo I think better to just copy what they've already done down rather than have a new implementation

No idea it was based on an external lib. That commit is even from 2014. I'll replace my implementation by the commit you mentioned.

[deponovo]

@WillAyd Pushed mods according to the requests. Now that I notice that pandas' ujson is based on an external lib, one might even consider updating the whole local code with the latest stable version of ujson.

[deponovo]

@WillAyd I just tested replacing the whole ujson base code with the latest version. The tests have the same result as per this PR. Should we instead perform that upgrade? I would only push after a positive answer.

[WillAyd]

I think we have some extensions in our code base that would be lost with a blanket update. If you wanted to do that its probably worth a dedicated issue and providing an analysis of the diff to see what might be changing.

For the scope of this PR, I think you are getting build failures from the definitions of DECLARE_NAN and DECLARE_INF that aren't being used

[WillAyd]

Looking reasonable. I think the failing test needs to be updated

[WillAyd]

@deponovo this PR looks good to me. Can you add a whatsnew note so users are aware of the enhancement?

@jreback over to you

[deponovo]

@deponovo this PR looks good to me. Can you add a whatsnew note so users are aware of the enhancement?

I am confused to how I should add an entry here. Should I had my text on v1.4.0? Not sure I fully understand the (reference)[https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#documenting-your-code] help.

[WillAyd]

@deponovo this PR looks good to me. Can you add a whatsnew note so users are aware of the enhancement?

I am confused to how I should add an entry here. Should I had my text on v1.4.0? Not sure I fully understand the (reference)[https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#documenting-your-code] help.

Yea 1.4 looks right. Should be good in the “Other Enhancements” section

https://github.com/pandas-dev/pandas/blob/master/doc/source/whatsnew/v1.4.0.rst#other-enhancements

[jreback]

thanks @deponovo very nice!

would certainly take an update to the ujson vendored code.

[jbrockmendel]

@deponovo any interest in porting more more improvements from upstream? in particular in ultrajsondec.c is looks like some overflow-handling improvements have been made.

[deponovo]

@jbrockmendel @jreback I already started with it. But there are some pandas specific code injections, so I can just swap code blindfolded. For now time is lacking. But I am working on it.