-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Update CI to include Translations from Scientific Python Repo #61380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ontent on the website
/preview |
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/61380/ |
Thanks @goanpeca for this. Do you mind adding some more context here? I can't see in https://github.com/Scientific-Python-Translations/pandas-translations much information, like what languages are available, or how to fix a bad translation, which would be useful to know. Also, in the docs generated from this PR I can see any language dropdown or anything different from our current docs. What are we expecting? |
Hi @datapythonista - this is a follow up to #61220, a proof-of-concept CI job to build the website with translations that don't live in this repo. This PR and #61220 are meant to work together and I'm happy to incorporate one into the other once we agree on the general direction and workflow for this. Let us know if we can answer any other questions. Unfortunately I'm not sure how to get the preview for the other PR, I relied on building locally to test that things were working. |
Sorry, I missed #61220 and the issue discussion. I don't fully understand what you're doing here, but I describe next how to add translations without adding too much complexity in this repo, which I don't think any core dev would be onboard with.
I think this makes everyone's life easy, and we get the expected result. |
Thanks @datapythonista ! Can you clarify what is missing from #61220 to match your description? That is pretty much what is done in that PR. Maybe this is confusing because we chose to do it in two parts exactly because we wanted to decouple the reorganization of the repo + switcher (in #61220) from the actual translations (this PR). Happy to follow up with any feedback in the other PR as well. Cheers! |
In #61220 you are moving all the current website pages, that should be undone. You are adding the translated pages to this repo, we don't want it. You are making changes to pandas_web.py, this is not needed based on what I described above. Only changes in a PR to this pandas repo should be addi g a CI step as per step 2, editing the wevsite template with the language dropdown as per step 3. |
I see! I will rework what I have there to match your proposal. Thanks! |
Hello team!
As part of the work that @melissawm is doing to showcase the translations work this PR shows how we could pull the translations from https://github.com/Scientific-Python-Translations/pandas-translations as part of the website build step.
cc @mroeschke