Skip to content

Bump minimum version of node + update superagent #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 7, 2024
Merged

Bump minimum version of node + update superagent #94

merged 5 commits into from
May 7, 2024

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented May 6, 2024 •
edited
Loading

What

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the package locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet mentioned this pull request May 6, 2024
Closed
6 tasks
@pcothenet pcothenet requested review from davidcornu, holtbp and a team May 6, 2024 21:37
pcothenet
pcothenet commented May 6, 2024
View reviewed changes
package.json
@@ -22,11 +21,11 @@
},
"dependencies": {
"query-string": "^7.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: updating this was causing a bunch of problems due to ES modules

davidcornu
davidcornu approved these changes May 7, 2024
View reviewed changes
.nvmrc
@@ -1 +1 @@
16.13.0
18.18.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably go all the way to 18.20.2 while we're at it (https://nodejs.org/en/about/previous-releases)

@pcothenet pcothenet merged commit e26521b into main May 7, 2024
3 checks passed
@pcothenet pcothenet deleted the pc/nodeversion branch May 7, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcornu davidcornu davidcornu approved these changes

@holtbp holtbp Awaiting requested review from holtbp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @davidcornu