Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I started working on an http client agnostic implementation with PSR-4 namespaces.
Let me know if you're interested to use it as a base for the official client :)
I would like to release it under the MIT license, but we can discuss it if you want.
Next steps are:
I used Httplug (http://docs.php-http.org/en/latest/index.html) as the client agnostic library, I'm aware that it brings a lot of dependencies but in the end I think it's worth it, you can use curl, or guzzle (the most used http client in the php world) or any other implementation that follows PSR-7.
I added a
composer.json
file to be able to register the package to Packagist, I took the liberty of usingpaylike
as the vendor if you want to use it (if not, I'll continue to develop my fork under another vendor name of course). In case you're willing to go with it, you will have to register it yourself on packagist and add the webhook on github.I saw in the previous todo file that you left the php world a while ago, so feel free to ask if you have any question regarding my choices :)
This is of course a work in progress, I didn't test it yet against a live application, so any feedback is appreciated