Fix [s]size_t types in ssh2_scp_send, also check written bytes in ssh2_scp_recv #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the streams documentation indicates a return type of
size_t
(and a warning that the prototypes are out of date), the current implementation isssize_t
.When using
size_t
, we get a build warning on this line (ignoring the small mismatch in line numbers):This PR ensures we use the correct types, both for the
libssh2
library calllibssh2_channel_write
, as well as the internal PHP functions.Moreover, I've added a check on the number of written bytes in the PHP function for
ssh2_scp_recv
. (If it's better to add this in another PR, let me know)