Skip to content

Add DefinitionConfigurator stub for rootNode ArrayNodeDefinition return type #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extension.neon
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ parameters:
- stubs/Symfony/Bundle/FrameworkBundle/Test/TestContainer.stub
- stubs/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/AuthenticatorFactoryInterface.stub
- stubs/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/FirewallListenerFactoryInterface.stub
- stubs/Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.stub
- stubs/Symfony/Component/Config/Definition/Configurator/DefinitionConfigurator.stub
- stubs/Symfony/Component/Console/Command.stub
- stubs/Symfony/Component/Console/Exception/ExceptionInterface.stub
- stubs/Symfony/Component/Console/Exception/InvalidArgumentException.stub
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

namespace Symfony\Component\Config\Definition\Builder;

class ArrayNodeDefinition
{

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

namespace Symfony\Component\Config\Definition\Configurator;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;

class DefinitionConfigurator
{

/**
* @return ArrayNodeDefinition
*/
public function rootNode();

}
6 changes: 6 additions & 0 deletions tests/Type/Symfony/ExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ public function dataFileAsserts(): iterable
yield from $this->gatherAssertTypes(__DIR__ . '/data/extension/with-configuration-with-constructor/WithConfigurationWithConstructorExtension.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/extension/with-configuration-with-constructor-optional-params/WithConfigurationWithConstructorOptionalParamsExtension.php');
yield from $this->gatherAssertTypes(__DIR__ . '/data/extension/with-configuration-with-constructor-required-params/WithConfigurationWithConstructorRequiredParamsExtension.php');

if (!class_exists('Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator')) {
return;
}

yield from $this->gatherAssertTypes(__DIR__ . '/data/definition_configurator.php');
}

/**
Expand Down
19 changes: 19 additions & 0 deletions tests/Type/Symfony/data/definition_configurator.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php declare(strict_types = 1);

use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\Configurator\DefinitionConfigurator;
use Symfony\Component\Config\Definition\Loader\DefinitionFileLoader;
use function PHPStan\Testing\assertType;

$treeBuilder = new TreeBuilder('my_tree');
$loader = new DefinitionFileLoader($treeBuilder, new \Symfony\Component\Config\FileLocator());

$configurator = new DefinitionConfigurator(
$treeBuilder,
$loader,
'',
''
);

$rootNode = $configurator->rootNode();
assertType('Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition', $rootNode);