Skip to content

Fixing open repository issue - Tensors on different devices #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

Fixing open repository issue - Tensors on different devices #238

merged 1 commit into from
Jul 31, 2023

Conversation

DosticJelena
Copy link
Contributor

Problem

Solving the problem described in the open repository issue.

Solution

Move all tensors to the same device defined at the beginning of the notebook.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@DosticJelena DosticJelena requested a review from jamescalam July 24, 2023 08:27
jamescalam
jamescalam approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jamescalam jamescalam merged commit 03611af into master Jul 31, 2023
@jamescalam jamescalam deleted the issues/abstractive-question-answering branch July 31, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescalam jamescalam jamescalam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DosticJelena @jamescalam