Skip to content

fix: Inconsistent Screen Reader Announcement for Word Wrap Toggle Button in Settings #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Inconsistent Screen Reader Announcement for Word Wrap Toggle Button in Settings #3476

wants to merge 2 commits into from

Conversation

Salman-in
Copy link

Fixes #3475

Changes:

  • Previously, when focusing on the toggle button (On/Off), the screen reader would announce "Line wrap is enabled/disabled", which differed from the expected terminology.
  • This has been updated so the screen reader now announces “Word Wrap is On/Off”, making it clearer and consistent with the visible label.
video-demo.mp4

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@welcome Welcome
Copy link

welcome bot commented May 10, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

yugalkaushik
yugalkaushik approved these changes May 11, 2025
View reviewed changes
Copy link
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salman-in
Copy link
Author

Hi @raclim, Could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yugalkaushik yugalkaushik yugalkaushik approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent Screen Reader Announcement for Word Wrap Toggle Button
2 participants
@Salman-in @yugalkaushik