Skip to content

Organize iotools reference page by data provider #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kandersolar
Copy link
Member

@kandersolar kandersolar commented Apr 23, 2025

  • Closes iotools reference page needs some organization #2446
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

See #2446. Docs build link: https://pvlib-python--2447.org.readthedocs.build/en/2447/reference/iotools.html

@kandersolar kandersolar added this to the v0.12.1 milestone Apr 23, 2025
@kandersolar kandersolar marked this pull request as ready for review April 23, 2025 18:12
Copy link
Contributor

@RDaxini RDaxini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be value in listing the sources in alphabetical order within each category?

Comment on lines +131 to 163
Commercial datasets
-------------------


SolarAnywhere
^^^^^^^^^^^^^

.. autosummary::
:toctree: generated/

iotools.get_solaranywhere
iotools.read_solaranywhere


Solcast
^^^^^^^

.. autosummary::
:toctree: generated/

iotools.get_solcast_tmy
iotools.get_solcast_historic
iotools.get_solcast_forecast
iotools.get_solcast_live


Solargis
^^^^^^^^

.. autosummary::
:toctree: generated/

iotools.get_solargis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be any value in listing in alphabetical order within each category? Example below for Commercial datasets:

Suggested change
Commercial datasets
-------------------
SolarAnywhere
^^^^^^^^^^^^^
.. autosummary::
:toctree: generated/
iotools.get_solaranywhere
iotools.read_solaranywhere
Solcast
^^^^^^^
.. autosummary::
:toctree: generated/
iotools.get_solcast_tmy
iotools.get_solcast_historic
iotools.get_solcast_forecast
iotools.get_solcast_live
Solargis
^^^^^^^^
.. autosummary::
:toctree: generated/
iotools.get_solargis
Commercial datasets
-------------------
SolarAnywhere
^^^^^^^^^^^^^
.. autosummary::
:toctree: generated/
iotools.get_solaranywhere
iotools.read_solaranywhere
Solargis
^^^^^^^^
.. autosummary::
:toctree: generated/
iotools.get_solargis
Solcast
^^^^^^^
.. autosummary::
:toctree: generated/
iotools.get_solcast_tmy
iotools.get_solcast_historic
iotools.get_solcast_forecast
iotools.get_solcast_live

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did struggle with choosing an ordering. For the free datasets, I ordered by what I guessed would be "most useful to the most users". I did not put any thought into the commercial dataset ordering.

Ordering by something easy and obvious would be nice. I'm open to switching to alphabetical (although it would be a shame to have to list the "not even solar resource" ACIS functions first...). I would like to hear from others on this point.

@@ -11,21 +11,39 @@ IO Tools
Functions for retrieving, reading, and writing data from a variety
of sources and file formats relevant to solar energy modeling.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. contents:: Currently supported APIs
:depth: 3
:local:

Thinking out loud in case you find this relevant.

You may as well try with the default (empty) title.
https://docutils.sourceforge.io/docs/ref/rst/directives.html#table-of-contents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iotools reference page needs some organization
3 participants