Skip to content

dev: Add Codecov Test Analytics to pydantic-core #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dev: Add Codecov Test Analytics to pydantic-core #1684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa6e8e
try this out first
ajay-sentry Apr 4, 2025
b0aa790
add junitxml
ajay-sentry Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

- run: uv pip freeze

- run: uv run coverage run -m pytest
- run: uv run coverage run -m pytest --junitxml=junit.xml -o junit_family=legacy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering: why can't Codecov read the "normal" coverage output file and needs a junitxml output?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting back, the JunitXML is needed to actually do the test analysis, because the normal coverage output file doesn't give us any test-specific information.


- run: ls -lha
- run: uv run coverage xml
Expand All @@ -55,6 +55,8 @@ jobs:

- uses: codecov/codecov-action@v5

- uses: codecov/test-results-action@v1

# See https://github.com/PyO3/pyo3/discussions/2781
# tests intermittently segfault with pypy and cpython 3.7 when using `coverage run ...`, hence separate job
test-python:
Expand Down
Loading