Skip to content

Fix all_to_all not using env pg #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix all_to_all not using env pg #2918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions torchrec/distributed/sharding/dynamic_sharding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ def shards_all_to_all(
sharded_t = state_dict[extend_shard_name(shard_name)]
assert param.ranks is not None
dst_ranks = param.ranks
state_dict[extend_shard_name(shard_name)]
# pyre-ignore
src_ranks = module.module_sharding_plan[shard_name].ranks

Expand Down Expand Up @@ -140,7 +139,7 @@ def shards_all_to_all(
input=local_input_tensor,
output_split_sizes=local_output_splits,
input_split_sizes=local_input_splits,
group=dist.group.WORLD,
group=env.process_group, # TODO: 2D uses env.sharding_pg
)

flattened_output_names_lengths = [
Expand Down
Loading