adsprpc: map the persist buffer outside the mutex #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, allocation and mapping of buffer is happening inside mutex.If mapping on one session gets stuck on DSP,other sessions will not be able to acquire the mutex and will get hung while getting spawned. Map the buffer outside the mutex. Signed-off-by: Patan Saddam <[email protected]>
| } | ||
| locked = false; |
quic-mtharu
reviewed
Oct 30, 2024
| @@ -3947,6 +3947,7 @@ static int domain_init(int domain, int *dev) { | |||
| } | |||
| VERIFY(AEE_SUCCESS == (nErr = fastrpc_mem_open(domain))); | |||
| VERIFY(AEE_SUCCESS == (nErr = apps_mem_init(domain))); | |||
| fastrpc_log_init(domain, dsppd); | |||
There was a problem hiding this comment.
Could you provide details about the variable being passed in this function? Is it a global variable, or might its declaration be missing?
quic-mtharu
reviewed
Oct 30, 2024
| * through script. */ | ||
| if ((dsppd == USERPD || dsppd == AUDIO_STATICPD || | ||
| dsppd == SENSORS_STATICPD) && debug_build_type) { | ||
| pthread_mutex_lock(&persist_buf.mut); |
There was a problem hiding this comment.
Could you please add error handling for the pthread_mutex_lock(mut) failure case? It’s important to ensure that the function gracefully handles any potential locking failures to maintain robustness.
There was a problem hiding this comment.
we are handing code gracefully when pthread_mutex_lock fails.
quic-mtharu
requested changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, allocation and mapping of buffer is happening inside mutex.If mapping on one session gets stuck on DSP,other sessions will not be able to acquire the mutex and will get hung while getting spawned. Map the buffer outside the mutex.