Skip to content

Moved source files to relevant folders #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

quickotemuth
Copy link

  • Arranged all the scource files into respective meaning full folders as shown below.
  • With respect to new location of files updated the auto make file (Makefile.am)  and adsprpc_blacklist.txt
  • Enabled sub directory option in automake.

Note: Native binaries, LA and LE build compiled successfully.

 

Source Files Folder
BufBound.c,   atomic.c,   cae.c,   gpls.c,   mod_table.c,   pl_list.c,   platform_libs.c,   smath.c,   std.c,   std_SwapBytes.c,   std_dtoa.c,   std_mem.c,   std_path.c,   std_strlprintf.c common
fastrpc_async.c,   fastrpc_cap.c,   fastrpc_config.c,   fastrpc_ioctl.c,   fastrpc_notif.c,   fastrpc_pm.c,   fastrpc_procbuf.c control
adsprpcd.c,   cdsprpcd.c,   dspsignal.c daemon
adspmsgd.c,   adspmsgd_printf.c,   fastrpc_log.c,   log_config.c debug
adsp_current_process1_stub.c,   adsp_current_process_stub.c,   adsp_default_listener1_stub.c,   adsp_default_listener_stub.c,   adsp_listener1_stub.c,   adsp_listener_stub.c,   adsp_perf1_stub.c,   adsp_perf_stub.c,   adspmsgd_adsp1_stub.c,   adspmsgd_adsp_stub.c,   adspmsgd_apps_skel.c,   apps_mem_skel.c,   apps_remotectl_skel.c,   apps_std_skel.c,   remotectl1_stub.c,   remotectl_stub.c dspInterface
adsp_default_listener.c,   apps_std_imp.c,   listener_android.c listener
apps_mem_imp.c,   fastrpc_mem.c,   rpcmem_linux.c memory
fastrpc_latency.c,   fastrpc_perf.c profile

… as shown below.

-  With respect to new location of files updated the auto make file (Makefile.am)  and adsprpc_blacklist.txt
- Enabled sub directory option in automake.

Signed-off-by: Kotesh Muthyala <[email protected]>
@quickotemuth quickotemuth force-pushed the folderArrangementQuic branch from 480c75b to 7974474 Compare October 22, 2024 12:33
adsp_perf1_stub.c \
mod_table.c
listener/listener_android.c \
listener/apps_std_imp.c \
Copy link
Contributor

@quic-bkumar quic-bkumar Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since apps_std is unrelated to the listener, we can relocate apps_std_imp.c to the file folder, as it contains the implementation for file system access.

listener/listener_android.c \
listener/apps_std_imp.c \
memory/apps_mem_imp.c \
dspInterface/apps_mem_skel.c \
Copy link
Contributor

@quic-bkumar quic-bkumar Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would be beneficial to consolidate all apps_mem related files into a single folder that represents all memory accesses from the DSP.

common/gpls.c \
dspInterface/remotectl_stub.c \
dspInterface/remotectl1_stub.c \
dspInterface/adspmsgd_apps_skel.c \
Copy link
Contributor

@quic-bkumar quic-bkumar Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like with memory, I think it would be beneficial to group this file under the debug folder.

dspInterface/adsp_current_process1_stub.c \
dspInterface/adsp_listener_stub.c \
dspInterface/adsp_listener1_stub.c \
dspInterface/apps_std_skel.c \
Copy link
Contributor

@quic-bkumar quic-bkumar Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grouping under "file" folder would be beneficial.

dspInterface/adspmsgd_adsp_stub.c \
dspInterface/adspmsgd_adsp1_stub.c \
dspInterface/apps_remotectl_skel.c \
dspInterface/adsp_current_process_stub.c \
Copy link
Contributor

@quic-rnallago quic-rnallago Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it would be more effective to group all app_skel and dsp_stub files into separate folders under dsp interface for better differentiation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants