-
Notifications
You must be signed in to change notification settings - Fork 33
Moved source files to relevant folders #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
… as shown below. - With respect to new location of files updated the auto make file (Makefile.am) and adsprpc_blacklist.txt - Enabled sub directory option in automake. Signed-off-by: Kotesh Muthyala <[email protected]>
480c75b
to
7974474
Compare
adsp_perf1_stub.c \ | ||
mod_table.c | ||
listener/listener_android.c \ | ||
listener/apps_std_imp.c \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since apps_std is unrelated to the listener, we can relocate apps_std_imp.c to the file folder, as it contains the implementation for file system access.
listener/listener_android.c \ | ||
listener/apps_std_imp.c \ | ||
memory/apps_mem_imp.c \ | ||
dspInterface/apps_mem_skel.c \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it would be beneficial to consolidate all apps_mem related files into a single folder that represents all memory accesses from the DSP.
common/gpls.c \ | ||
dspInterface/remotectl_stub.c \ | ||
dspInterface/remotectl1_stub.c \ | ||
dspInterface/adspmsgd_apps_skel.c \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like with memory, I think it would be beneficial to group this file under the debug folder.
dspInterface/adsp_current_process1_stub.c \ | ||
dspInterface/adsp_listener_stub.c \ | ||
dspInterface/adsp_listener1_stub.c \ | ||
dspInterface/apps_std_skel.c \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grouping under "file" folder would be beneficial.
dspInterface/adspmsgd_adsp_stub.c \ | ||
dspInterface/adspmsgd_adsp1_stub.c \ | ||
dspInterface/apps_remotectl_skel.c \ | ||
dspInterface/adsp_current_process_stub.c \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it would be more effective to group all app_skel and dsp_stub files into separate folders under dsp interface for better differentiation.
Note: Native binaries, LA and LE build compiled successfully.