Skip to content

feat: support for bytes and num inline formatting #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2025
Merged

feat: support for bytes and num inline formatting #740

merged 4 commits into from
Apr 25, 2025

Conversation

m-muecke
Copy link
Contributor

@m-muecke m-muecke commented Nov 10, 2024 •
edited
Loading

closes #644, #588, #643

@gaborcsardi
Copy link
Member

Thanks and sorry for the long wait! I am not a big fan of optional dependencies. Luckily, R/sizes.R now has prettycode::pretty_bytes() embedded, and we could probably do that same for pretty_num()?

@m-muecke
Copy link
Contributor Author

Thanks and sorry for the long wait! I am not a big fan of optional dependencies. Luckily, R/sizes.R now has prettycode::pretty_bytes() embedded, and we could probably do that same for pretty_num()?

done

@gaborcsardi gaborcsardi merged commit 711fb24 into r-lib:main Apr 25, 2025
16 checks passed
@gaborcsardi
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Formatting for bytes?
2 participants
@m-muecke @gaborcsardi