format code by running make fmt #3011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peczenyj
force-pushed
the
apply-make-fmt
branch
from
642e2cb to
cb78de8
Compare
ndyakov
previously approved these changes
Mar 24, 2025
|
@peczenyj would you mind resolving the conflicts? |
|
@peczenyj I doublechecked and also executed |
I rerun the make fmt in master and the difference is minimal. I don't think this MR is necessary if the idea is to remove the changes added by gofumpt with extra option. I will close it, feel free to reopen if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just run
make fmtalso I just run gofumpt with -extra because... why not?