Skip to content

migrate golangci-lint config to v2 format #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 29, 2025
Merged

migrate golangci-lint config to v2 format #3354

merged 8 commits into from
Apr 29, 2025

Conversation

ofekshenawa
Copy link
Collaborator

@ofekshenawa ofekshenawa commented Apr 20, 2025 •
edited by ndyakov
Loading

  • bump config schema to version “2”
  • re‑add 5m timeout under run
  • enable config verification in GitHub Action (verify: true)
  • Address several golangci-lint/staticcheck warnings:
    • Use a tagged switch instead of an if/else if chain on readType

@ofekshenawa ofekshenawa marked this pull request as ready for review April 23, 2025 20:25
@ofekshenawa ofekshenawa mentioned this pull request Apr 23, 2025
Closed
@ofekshenawa ofekshenawa added dependencies Pull requests that update a dependency file maintenance labels Apr 23, 2025
@ofekshenawa ofekshenawa self-assigned this Apr 24, 2025
ndyakov
ndyakov requested changes Apr 24, 2025
View reviewed changes
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's work on setting up the staticcheck in such a way that it won't require us to sacrifice on readability just to lint the code.

ndyakov
ndyakov approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think this is a good configuration to start from.

@ndyakov ndyakov merged commit 2f0a9b7 into master Apr 29, 2025
16 checks passed
@ndyakov ndyakov deleted the os-migrate-golang-ci-to-new-version-format branch April 29, 2025 09:53
ndyakov pushed a commit that referenced this pull request Apr 30, 2025
@ofekshenawa @ndyakov
migrate golangci-lint config to v2 format (#3354)
09dc351 
* migrate golangci-lint config to v2 format

* chore: skip CI on migration [skip ci]

* Bump golangci version

* Address several golangci-lint/staticcheck warnings

* change staticchecks settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndyakov ndyakov ndyakov approved these changes

@htemelski htemelski Awaiting requested review from htemelski

@elena-kolevska elena-kolevska Awaiting requested review from elena-kolevska

Assignees

@ofekshenawa ofekshenawa

Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofekshenawa @ndyakov @elena-kolevska