-
Notifications
You must be signed in to change notification settings - Fork 45
Remove non-essential tabulate and coloredlogs dependencies #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@justin-cechmanek FYI when I pull this branch, clean out my poetry environment, and reinstall from here, I get this:
Not sure how this is possible though as I see the jsonpath_ng dependency didn't change here. Otherwise looks good. |
Testing this out on a fresh virtual env I can't reproduce the jsonpath_ng bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Another thing you could do to try and repro the issue Tyler mentioned is build a wheel with poetry build
and install that into a new environment.
I'm not yet what to do with this yet -- was anyone else able to reproduce my issue? @justin-cechmanek @abrookins @rbs333 |
Trying now! |
Issue resolved. |
No description provided.