Skip to content

Remove non-essential tabulate and coloredlogs dependencies #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

justin-cechmanek
Copy link
Collaborator

No description provided.

@tylerhutcherson tylerhutcherson added the enhancement New feature or request label Apr 29, 2025
@tylerhutcherson tylerhutcherson changed the title removes tabulate and coloredlogs dependencies Remove non-essential tabulate and coloredlogs dependencies Apr 29, 2025
@tylerhutcherson
Copy link
Collaborator

tylerhutcherson commented Apr 29, 2025

@justin-cechmanek FYI when I pull this branch, clean out my poetry environment, and reinstall from here, I get this:

$ python
Python 3.13.2 (main, Feb 11 2025, 12:22:04) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from redisvl.index import SearchIndex
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    from redisvl.index import SearchIndex
  File "/Users/tyler.hutcherson/Documents/AppliedAI/redis-vl-python/redisvl/index/__init__.py", line 1, in <module>
    from redisvl.index.index import AsyncSearchIndex, SearchIndex
  File "/Users/tyler.hutcherson/Documents/AppliedAI/redis-vl-python/redisvl/index/index.py", line 22, in <module>
    from redisvl.query.query import VectorQuery
  File "/Users/tyler.hutcherson/Documents/AppliedAI/redis-vl-python/redisvl/query/__init__.py", line 1, in <module>
    from redisvl.query.aggregate import AggregationQuery, HybridQuery
  File "/Users/tyler.hutcherson/Documents/AppliedAI/redis-vl-python/redisvl/query/aggregate.py", line 6, in <module>
    from redisvl.redis.utils import array_to_buffer
  File "/Users/tyler.hutcherson/Documents/AppliedAI/redis-vl-python/redisvl/redis/utils.py", line 7, in <module>
    from redisvl.schema.fields import VectorDataType
  File "/Users/tyler.hutcherson/Documents/AppliedAI/redis-vl-python/redisvl/schema/__init__.py", line 17, in <module>
    from redisvl.schema.validation import validate_object
  File "/Users/tyler.hutcherson/Documents/AppliedAI/redis-vl-python/redisvl/schema/validation.py", line 11, in <module>
    from jsonpath_ng import parse as jsonpath_parse
ModuleNotFoundError: No module named 'jsonpath_ng'

Not sure how this is possible though as I see the jsonpath_ng dependency didn't change here.

Otherwise looks good.

@justin-cechmanek
Copy link
Collaborator Author

Testing this out on a fresh virtual env I can't reproduce the jsonpath_ng bug

Copy link
Collaborator

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Another thing you could do to try and repro the issue Tyler mentioned is build a wheel with poetry build and install that into a new environment.

@tylerhutcherson
Copy link
Collaborator

I'm not yet what to do with this yet -- was anyone else able to reproduce my issue? @justin-cechmanek @abrookins @rbs333

@abrookins
Copy link
Collaborator

I'm not yet what to do with this yet -- was anyone else able to reproduce my issue? @justin-cechmanek @abrookins @rbs333

Trying now!

@abrookins abrookins merged commit 8435e05 into 0.6.0 Apr 30, 2025
31 checks passed
@tylerhutcherson
Copy link
Collaborator

I'm not yet what to do with this yet -- was anyone else able to reproduce my issue? @justin-cechmanek @abrookins @rbs333

Issue resolved.

@tylerhutcherson tylerhutcherson deleted the feat/RAAE-780/remove-dependencies branch May 1, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants