robotpy-build meson rewrite #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtuald
force-pushed
the
semiwrap
branch
3 times, most recently
from
1dbdd26 to
8e00162
Compare
virtuald
force-pushed
the
next
branch
2 times, most recently
from
dc04cfc to
3f79005
Compare
- This is because the generator will need to know that a trampoline is potentially being generated only by parsing pyproject.toml/autogen yaml
- Switch to src layout - Docs not updated - internals not fully updated
virtuald
force-pushed
the
semiwrap
branch
2 times, most recently
from
44ac7de to
3a91495
Compare
- Builds multiple projects that use things from each other
virtuald
force-pushed
the
semiwrap
branch
2 times, most recently
from
ac303be to
c0d45b7
Compare
auscompgeek
reviewed
May 6, 2025
| try: | ||
| from distutils.util import get_platform as _get_platform | ||
| except ImportError: | ||
| from sysconfig import get_platform as _get_platform |
There was a problem hiding this comment.
Is there a reason to try distutils.util first? Could we just always use sysconfig.get_platform?
There was a problem hiding this comment.
I think their behavior is slightly different. Honestly, I'd like to get rid of this whole file anyways, I need to port robotpy-ctre and get mostrobotpy working in CI to see if it's possible first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily for CI testing at the moment.
python_requires#140