Skip to content

Lifecycle Publishers and Subscriptions should not be Discovered by the ROS 2 Network until Configured #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amronos opened this issue Apr 11, 2025 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Amronos
Copy link

Amronos commented Apr 11, 2025

Description

Lifecycle Publishers and Subscriptions (being implemented with #2715) should not be discovered by the ROS 2 network until the Lifecycle Node has entered the inactive state (meaning it is configured)

This was originally brought up by @fujitatomoya in #2715 (comment).

Motivation

This will allow one to determine whether a node is actually publishing/subscribing to a particular topic. It doesn't make sense to list lifecycle nodes as publishing/subscribing to a specific topic when they haven't even been configured.

Design / Implementation Considerations

The following way to implement this has been suggested by @fujitatomoya in #2715 (comment):

for doing that, probably we need to have state control (configured, inactive) in SubscriberBase class and underlying implementations, and then on_configure callback, we can configure the subscription to be discovered.

Additional Information

No response

@Amronos Amronos added the enhancement New feature or request label Apr 11, 2025
@MichaelOrlov MichaelOrlov added the help wanted Extra attention is needed label Apr 24, 2025
@MichaelOrlov
Copy link
Contributor

To be discussed at the client WG meeting.
cc: @mjcarroll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants