Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

docs: fix documentation about linter behavior #730

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

FooBarWidget
Copy link
Contributor

@FooBarWidget FooBarWidget commented Apr 25, 2021

The troubleshooting document says that linters are run from the workspace root:

All commands are run with a cwd of the workspace root.

However, as reported in #717, linters are in fact not run from the workspace root.

This comment says that not running from the workspace root is intentional. It allows people to put multiple linter configuration files in the project. We expect linters to look recursively up the directory tree to find their configuration file.

This means that the behavior is not a bug. The documentation is wrong.

This pull request fixes the documentation.

  • The build passes
  • TSLint is mostly happy — I didn't touch any .ts files
  • Prettier has been run — I didn't touch any .ts files

@github-actions
Copy link

This PR has not had activity for 30 days. It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label May 26, 2021
@FooBarWidget
Copy link
Contributor Author

FooBarWidget commented May 26, 2021

Please don't auto close this PR. It's awaiting review.

@github-actions github-actions bot removed the stale label May 27, 2021
@github-actions
Copy link

This PR has not had activity for 30 days. It will be automatically closed in 7 days.

@github-actions github-actions bot added the stale label Jul 30, 2021
@FooBarWidget
Copy link
Contributor Author

Please don't auto close this PR. It's awaiting review.

@github-actions github-actions bot removed the stale label Jul 31, 2021
@wingrunr21 wingrunr21 merged commit 6b5788c into rubyide:main Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants