Skip to content

WIP: Trusted Publishing #11056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d6fa9d9
diesel_helpers: Adjust `lower()` fn to also accept `NULL`
Turbo87 May 8, 2025
6eda81f
trustpub: Implement `load_jwks()` fn
Turbo87 May 7, 2025
512c762
trustpub: Add `GITHUB_ISSUER_URL` constant
Turbo87 May 7, 2025
9ed85fa
trustpub: Add `OidcKeyStore` trait
Turbo87 May 7, 2025
a0592db
trustpub: Implement `OidcKeyStore` trait
Turbo87 May 7, 2025
31e6708
trustpub: Add mock `OidcKeyStore` implementation
Turbo87 May 7, 2025
6a2caee
trustpub: Add RSA keys for testing purposes
Turbo87 May 7, 2025
b5eb62b
trustpub: Add `MockOidcKeyStore::with_test_key()` fn
Turbo87 May 8, 2025
83ce793
trustpub: Implement `extract_workflow_filename()` fn
Turbo87 May 7, 2025
222b2b8
trustpub: Implement `UnverifiedClaims::decode()` fn
Turbo87 May 7, 2025
8a2abad
trustpub: Implement `GitHubClaims` struct
Turbo87 May 7, 2025
35d61c0
trustpub: Implement `FullGitHubClaims` struct for testing purposes
Turbo87 May 8, 2025
8cf78d8
trustpub: Implement `AccessToken` struct
Turbo87 May 8, 2025
6928349
database: Add `NewUsedJti` data access object
Turbo87 Apr 28, 2025
83be81e
database: Add `NewToken` data access object
Turbo87 Apr 28, 2025
e3a2835
config: Add `TRUSTPUB_AUDIENCE` setting
Turbo87 May 8, 2025
b2ace7b
App: Add `oidc_key_stores` hashmap
Turbo87 May 7, 2025
d203be6
AppBuilder: Add `trustpub_providers()` fn
Turbo87 May 8, 2025
3cd0e7b
bin/server: Use `TRUSTPUB_PROVIDERS` env var to configure Trusted Pub…
Turbo87 May 8, 2025
a60534f
tests/TestAppBuilder: Add `with_oidc_keystore()` fn
Turbo87 May 7, 2025
4006490
Implement `PUT /api/v1/trusted_publishing/tokens` API endpoint
Turbo87 May 8, 2025
ced1120
tests/util: Change `MockTokenUser::token` to be optional
Turbo87 Apr 16, 2025
c42ea6e
tests/util: Add `MockTokenUser::for_token()` fn
Turbo87 Apr 16, 2025
106ef4d
database/NewVersion: Make `published_by_email` argument of `save()` f…
Turbo87 May 7, 2025
986a71d
WIP
Turbo87 May 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ paste = "=1.0.15"
postgres-native-tls = "=0.5.1"
prometheus = { version = "=0.14.0", default-features = false }
rand = "=0.9.1"
regex = "=1.11.1"
reqwest = { version = "=0.12.15", features = ["gzip", "json"] }
rss = { version = "=2.0.12", default-features = false, features = ["atom"] }
secrecy = "=0.10.3"
Expand Down Expand Up @@ -143,11 +144,12 @@ crates_io_index = { path = "crates/crates_io_index", features = ["testing"] }
crates_io_tarball = { path = "crates/crates_io_tarball", features = ["builder"] }
crates_io_team_repo = { path = "crates/crates_io_team_repo", features = ["mock"] }
crates_io_test_db = { path = "crates/crates_io_test_db" }
crates_io_trustpub = { path = "crates/crates_io_trustpub", features = ["test-helpers"] }
claims = "=0.8.0"
diesel = { version = "=2.2.10", features = ["r2d2"] }
googletest = "=0.14.0"
insta = { version = "=1.43.1", features = ["glob", "json", "redactions"] }
regex = "=1.11.1"
jsonwebtoken = "=9.3.1"
sentry = { version = "=0.37.0", features = ["test"] }
tokio = "=1.45.0"
zip = { version = "=2.6.1", default-features = false, features = ["deflate"] }
3 changes: 2 additions & 1 deletion crates/crates_io_database/src/models/category.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use crate::schema::*;
use chrono::{DateTime, Utc};
use diesel::dsl;
use diesel::prelude::*;
use diesel::sql_types::Text;
use diesel_async::scoped_futures::ScopedFutureExt;
use diesel_async::{AsyncConnection, AsyncPgConnection, RunQueryDsl};
use futures_util::future::BoxFuture;
Expand All @@ -20,7 +21,7 @@ pub struct Category {
pub created_at: DateTime<Utc>,
}

type WithSlug<'a> = dsl::Eq<categories::slug, crates_io_diesel_helpers::lower<&'a str>>;
type WithSlug<'a> = dsl::Eq<categories::slug, crates_io_diesel_helpers::lower<Text, &'a str>>;

#[derive(Associations, Insertable, Identifiable, Debug, Clone, Copy)]
#[diesel(
Expand Down
4 changes: 4 additions & 0 deletions crates/crates_io_database/src/models/trustpub/mod.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
mod github_config;
mod token;
mod used_jti;

pub use self::github_config::{GitHubConfig, NewGitHubConfig};
pub use self::token::NewToken;
pub use self::used_jti::NewUsedJti;
22 changes: 22 additions & 0 deletions crates/crates_io_database/src/models/trustpub/token.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
use crate::schema::trustpub_tokens;
use chrono::{DateTime, Utc};
use diesel::prelude::*;
use diesel_async::{AsyncPgConnection, RunQueryDsl};

#[derive(Debug, Insertable)]
#[diesel(table_name = trustpub_tokens, check_for_backend(diesel::pg::Pg))]
pub struct NewToken<'a> {
pub expires_at: DateTime<Utc>,
pub hashed_token: &'a [u8],
pub crate_ids: &'a [i32],
}

impl NewToken<'_> {
pub async fn insert(&self, conn: &mut AsyncPgConnection) -> QueryResult<()> {
self.insert_into(trustpub_tokens::table)
.execute(conn)
.await?;

Ok(())
}
}
24 changes: 24 additions & 0 deletions crates/crates_io_database/src/models/trustpub/used_jti.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
use crate::schema::trustpub_used_jtis;
use chrono::{DateTime, Utc};
use diesel::prelude::*;
use diesel_async::{AsyncPgConnection, RunQueryDsl};

#[derive(Debug, Insertable)]
#[diesel(table_name = trustpub_used_jtis, check_for_backend(diesel::pg::Pg))]
pub struct NewUsedJti<'a> {
pub jti: &'a str,
pub expires_at: DateTime<Utc>,
}

impl<'a> NewUsedJti<'a> {
pub fn new(jti: &'a str, expires_at: DateTime<Utc>) -> Self {
Self { jti, expires_at }
}

pub async fn insert(&self, conn: &mut AsyncPgConnection) -> QueryResult<usize> {
diesel::insert_into(trustpub_used_jtis::table)
.values(self)
.execute(conn)
.await
}
}
20 changes: 11 additions & 9 deletions crates/crates_io_database/src/models/version.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ pub struct NewVersion<'a> {
license: Option<&'a str>,
#[builder(default, name = "size")]
crate_size: i32,
published_by: i32,
published_by: Option<i32>,
checksum: &'a str,
links: Option<&'a str>,
rust_version: Option<&'a str>,
Expand All @@ -110,7 +110,7 @@ impl NewVersion<'_> {
pub async fn save(
&self,
conn: &mut AsyncPgConnection,
published_by_email: &str,
published_by_email: Option<&str>,
) -> QueryResult<Version> {
use diesel::insert_into;

Expand All @@ -122,13 +122,15 @@ impl NewVersion<'_> {
.get_result(conn)
.await?;

insert_into(versions_published_by::table)
.values((
versions_published_by::version_id.eq(version.id),
versions_published_by::email.eq(published_by_email),
))
.execute(conn)
.await?;
if let Some(published_by_email) = published_by_email {
insert_into(versions_published_by::table)
.values((
versions_published_by::version_id.eq(version.id),
versions_published_by::email.eq(published_by_email),
))
.execute(conn)
.await?;
}

Ok(version)
}
Expand Down
2 changes: 1 addition & 1 deletion crates/crates_io_diesel_helpers/src/fns.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use diesel::sql_types::{Date, Double, Integer, Interval, SingleValue, Text, Time
define_sql_function!(#[aggregate] fn array_agg<T: SingleValue>(x: T) -> Array<T>);
define_sql_function!(fn canon_crate_name(x: Text) -> Text);
define_sql_function!(fn to_char(a: Date, b: Text) -> Text);
define_sql_function!(fn lower(x: Text) -> Text);
define_sql_function!(fn lower<T: SingleValue>(x: T) -> T);
define_sql_function!(fn date_part(x: Text, y: Timestamptz) -> Double);
define_sql_function! {
#[sql_name = "date_part"]
Expand Down
22 changes: 21 additions & 1 deletion crates/crates_io_trustpub/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,30 @@ edition = "2024"
[lints]
workspace = true

[features]
test-helpers = ["dep:bon", "dep:mockall", "dep:serde_json"]

[dependencies]
anyhow = "=1.0.98"
async-trait = "=0.1.88"
bon = { version = "=3.6.3", optional = true }
chrono = { version = "=0.4.41", features = ["serde"] }
jsonwebtoken = "=9.3.1"
mockall = { version = "=0.13.1", optional = true }
rand = "=0.9.1"
reqwest = { version = "=0.12.15", features = ["gzip", "json"] }
regex = "=1.11.1"
secrecy = "=0.10.3"
serde = { version = "=1.0.219", features = ["derive"] }
serde_json = { version = "=1.0.140", optional = true }
sha2 = "=0.10.9"
thiserror = "=2.0.12"
tokio = { version = "=1.45.0", features = ["sync"] }

[dev-dependencies]
bon = "=3.6.3"
claims = "=0.8.0"
insta = "=1.43.1"
insta = { version = "=1.43.1", features = ["json", "redactions"] }
mockito = "=1.7.0"
serde_json = "=1.0.140"
tokio = { version = "=1.45.0", features = ["macros", "rt-multi-thread"] }
Loading
Loading