Add new temporary lifetime extension rule #1813
Conversation
rustbot
added
the
S-waiting-on-review
|
@WaffleLapkin I vaguely remember you were working on rewriting this section at some point? Maybe I misremember. |
|
I indeed found this message:
I did forget about it and can't find any changes I did back then, so I'd assume I haven't even started rewriting it. I'll write this down so I don't forget again ^^' |
|
This looks correct to me. |
| [tuple struct]: types/struct.md#r-type.struct.tuple | ||
| [tuple variant]: types/enum.md#r-type.enum.declaration |
There was a problem hiding this comment.
Let's switch these out for the r identifiers.
| @@ -374,10 +374,10 @@ expression which is one of the following: | |||
| expression], [braced struct][struct expression], or [tuple][tuple expression] | |||
| expression. | |||
| * The final expression of any extending [block expression]. | |||
| * The arguments to [tuple struct][tuple struct] and [tuple variant][tuple variant] constructors. | |||
There was a problem hiding this comment.
| * The arguments to [tuple struct][tuple struct] and [tuple variant][tuple variant] constructors. | |
| * The arguments to [tuple struct] and [tuple variant] constructors. |
| @@ -374,10 +374,10 @@ expression which is one of the following: | |||
| expression], [braced struct][struct expression], or [tuple][tuple expression] | |||
| expression. | |||
| * The final expression of any extending [block expression]. | |||
| * The arguments to [tuple struct][tuple struct] and [tuple variant][tuple variant] constructors. | |||
There was a problem hiding this comment.
We were uncertain about two things here:
- What is an "extending ... expression"? Does that mean it is a subexpression of something else that is extending?
- Related to that, do these need the adjective "extending"? That is, "extending tuple struct" and "extending tuple variant"? If so, would it make sense to merge this with the third bullet point, or at least to move this bullet point to be next to it?
There was a problem hiding this comment.
I think to answer my own question, I do believe the "extending" part is relevant. My understanding is that:
Some{0: &temp()}— ok(Some{0: &temp()},)— okfoo(Some{0: &temp()},)— ERROR
because in function call argument position it is not an "extending expression". The same seems to be true for tuple constructors in rust-lang/rust#140593:
Some(&temp())— ok(Some(&temp()),)— okfoo(Some(&temp()),)— ERROR
ehuss
added
S-waiting-on-author
See rust-lang/rust#140593