Skip to content

PassWrapper: adapt for llvm/llvm-project@f137c3d592e96330e450a8fd63ef… #140534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PassWrapper: adapt for llvm/llvm-project@f137c3d592e96330e450a8fd63ef… #140534

wants to merge 1 commit into from
+5 −0

Conversation

erickt
Copy link
Contributor

@erickt erickt commented May 1, 2025

…7e8877fc1908

In LLVM 21 PR llvm/llvm-project#130940 TargetRegistry::createTargetMachine was changed to take a const Triple& and has deprecated the old StringRef method.

@rustbot label llvm-main

@rustbot
Copy link
Collaborator

rustbot commented May 1, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels May 1, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
cuviper
cuviper approved these changes May 1, 2025
View reviewed changes
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once tidy comes back clean.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@erickt
PassWrapper: adapt for llvm/llvm-project@f137c3d
951412e 
In LLVM 21 PR llvm/llvm-project#130940
`TargetRegistry::createTargetMachine` was changed to take a `const
Triple&` and has deprecated the old `StringRef` method.

@rustbot label llvm-main
@erickt
Copy link
Contributor Author

erickt commented May 1, 2025

@cuviper looks like I got it clean (darn pesky tabs), so I think it's ready to go.

@cuviper
Copy link
Member

cuviper commented May 1, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 1, 2025

📌 Commit 951412e has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2025
VlaDexa added a commit to VlaDexa/rust that referenced this pull request May 2, 2025
@VlaDexa
Rollup merge of rust-lang#140534 - erickt:llvm-21, r=cuviper
1a39f0e 
PassWrapper: adapt for llvm/llvm-project@f137c3d592e96330e450a8fd63ef…

…7e8877fc1908

In LLVM 21 PR llvm/llvm-project#130940 `TargetRegistry::createTargetMachine` was changed to take a `const Triple&` and has deprecated the old `StringRef` method.

`@rustbot` label llvm-main
@VlaDexa VlaDexa mentioned this pull request May 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper approved these changes

Assignees

@cuviper cuviper

Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erickt @rustbot @rust-log-analyzer @cuviper @bors