Rollup of 7 pull requests #140613
Merged
Rollup of 7 pull requests #140613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These randomly break when i change the implementation of format_args!().
…e one with revisions
resolve: Support imports of associated types and glob imports from traits Follow up to rust-lang#134754, part of rust-lang#134691. This PR also closes rust-lang#138711 now. Prohibiting `use Trait::AssocType;` at name resolution stage doesn't make sense, the name itself is perfectly resolveable. It's a type checker's problem that the necessary generic args are not passed when the imported `AssocType` is used, so an error should be reported there. And since we can import associated trait items now, glob imports from traits can also be allowed.
…etrochenkov organize and extend forbidden target feature tests In particular this adds some loongarch tests for rust-lang#135015, Cc `@heiher` Seems like the tests change so much git does not detect the renames; a commit-by-commit review should help. try-job: `x86_64-gnu-llvm-20-*`
…errors Remove fragile equal-pointers-unequal tests. Same as rust-lang#139176 --- These tests were added in rust-lang#127003 These tests stop working when I change implementation details of format_args!(). These tests shouldn't rely on such implementation details. Do these tests test anything that isn't already covered by other tests? If so, they should be expressed in a less fragile way that doesn't rely on internal details of format_args!(). cc `@GrigorenkoPV,` author of these tests.
…obzol Update sysinfo to `0.35.0` in bootstrap and `tools/opt-dist` This release is mostly bugfixes and code improvements.
…ypo, r=cuviper doc(std): fix typo lchown -> lchmod chown is irrelevant here, as this function does not affect file ownership. chmod is the correct function to reference here.
zkvm: remove schmerik as target maintainer I am no longer actively working on this target so I would like to be dropped from this list.
…r-errors yet another small borrowck cleanup The last borrowck changes from rust-lang#139587 which can be reviewed entirely separately. r? `@compiler-errors`
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing d7df5bd (parent) -> 097cd98 (this PR) Test differencesShow 120 test diffsStage 1
Stage 2
(and 8 additional test diffs) Additionally, 12 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 097cd98869cf07a2860bef16c0d4a2b3b019b23a --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: d7df5bdf29 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 3, 2025
|
Finished benchmarking commit (097cd98): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.8%, secondary -1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.259s -> 768.722s (-0.20%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
0.35.0in bootstrap andtools/opt-dist#140582 (Update sysinfo to0.35.0in bootstrap andtools/opt-dist)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup