Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23033
This commit just ensures unused annotation is retained for parameters. The previous tweak excluded constructor params (probably out of fear).
My limited understanding is that the meta annots decide what to do for fields: which elements receive the annotation.
For a class param, I assumed you don't know whether a param incurs a field until constructors. Does a using param always incur a field?
For the fix, follow the example of
publicInBinary
to retain the annotation.A justification is that if I ask not to warn, I always mean don't warn about any of the things, so extra unused annotations is benign.
Should unused have the param meta annot? It is redundant because if there is a field, you will always use the param through a paramaccessor, which is either the field itself or the getter, and both will be annotated unused.