Skip to content

Ensure that ssl option is read as expected #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evz
Copy link

@evz evz commented Apr 8, 2025

Hello there! I was attempting to mock out the calls to the Segment API for the purposes of load testing and found that if you set the ssl option to false (which is what you would expect to work), the way that the code was written in the Transport class, meant that it was always being set to the default (since options[:ssl] evaluates to false, using the ||= operator always flipped it back to true aka the default).

This attempts to fix that issue by making it so that setting ssl to anything other than true will cause it to be set to false. I expect that this will more than likely be fine since this isn't really even documented as an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant