Ensure that ssl option is read as expected #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! I was attempting to mock out the calls to the Segment API for the purposes of load testing and found that if you set the
ssl
option tofalse
(which is what you would expect to work), the way that the code was written in theTransport
class, meant that it was always being set to the default (sinceoptions[:ssl]
evaluates tofalse
, using the||=
operator always flipped it back totrue
aka the default).This attempts to fix that issue by making it so that setting
ssl
to anything other thantrue
will cause it to be set tofalse
. I expect that this will more than likely be fine since this isn't really even documented as an option.