Skip to content

Fix VectorStoreDocumentRetriever to handle Filter.Expression objects #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix VectorStoreDocumentRetriever to handle Filter.Expression objects #3194

wants to merge 1 commit into from
+50 −2

Conversation

markpollack
Copy link
Member

  • Updated computeRequestFilterExpression to check if the context value is already a Filter.Expression object before attempting to parse it as a string
  • Added docs for FILTER_EXPRESSION key that it accepts both String and Filter.Expression
  • Added test

Fixes #3179

@markpollack
Fix VectorStoreDocumentRetriever to handle Filter.Expression objects …
24dae13 
…directly

- Updated computeRequestFilterExpression to check if the context value is already
  a Filter.Expression object before attempting to parse it as a string
- Added docs for FILTER_EXPRESSION key that it accepts both String and Filter.Expression
- Added test

Fixes #3179
@markpollack markpollack added this to the 1.0.0 milestone May 15, 2025
@markpollack markpollack added the RAG Issues related to Retrieval Augmented Generation label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ilayaperumalg ilayaperumalg

Labels
RAG Issues related to Retrieval Augmented Generation
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

VectorStoreDocumentRetriever does not use the Filter.Expression object
2 participants
@markpollack @ilayaperumalg