Skip to content

org/springframework/boot/logging/log4j2/log4j2.xml should not expose a FILE_LOG_PATTERN property as it only configures the console appender #45509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented May 13, 2025

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 13, 2025
@spring-projects spring-projects deleted a comment May 13, 2025
@spring-projects spring-projects deleted a comment May 13, 2025
@philwebb
Copy link
Member

philwebb commented May 13, 2025

I don't think we've documented it, but I guess it's possible someone might be including that configuration and using the property. I think the risk is small, but just to be safe lets only do this in 4.0.x

@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels May 13, 2025
@philwebb philwebb added this to the 4.0.x milestone May 13, 2025
@snicoll snicoll added type: bug A general bug and removed type: task A general task labels May 14, 2025
@snicoll snicoll changed the title Remove unused property from log4j2.xml Remove unused property from log4j2.xml should not expose a FILE_LOG_PATTERN property as it only configures the console appender May 14, 2025
@snicoll snicoll changed the title Remove unused property from log4j2.xml should not expose a FILE_LOG_PATTERN property as it only configures the console appender org/springframework/boot/logging/log4j2/log4j2.xml should not expose a FILE_LOG_PATTERN property as it only configures the console appender May 14, 2025
@snicoll snicoll self-assigned this May 14, 2025
@snicoll snicoll modified the milestones: 4.0.x, 4.0.0-M1 May 14, 2025
snicoll pushed a commit that referenced this pull request May 14, 2025
snicoll added a commit that referenced this pull request May 14, 2025
* pr/45509:
  Remove FILE_LOG_PATTERN property from console-only log4j2.xml

Closes gh-45509
@snicoll
Copy link
Member

snicoll commented May 14, 2025

Merged in ee90996

@snicoll snicoll closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants