Skip to content

Polish MetricsAutoConfiguration #45521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

quaff
Copy link
Contributor

@quaff quaff commented May 13, 2025

Align meterRegistryPostProcessor with meterRegistryCloser, the @Bean method shouldn't be public if the return type is not public.

Align `meterRegistryPostProcessor` with `meterRegistryCloser`, the `@Bean` method shouldn't be public if the return type is not public.

Signed-off-by: Yanming Zhou <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 13, 2025
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels May 13, 2025
@snicoll snicoll added this to the 4.0.x milestone May 13, 2025
@snicoll snicoll self-assigned this May 13, 2025
@snicoll snicoll modified the milestones: 4.0.x, 4.0.0-M1 May 13, 2025
snicoll pushed a commit that referenced this pull request May 13, 2025
Align `meterRegistryPostProcessor` with `meterRegistryCloser`, the
`@Bean` method shouldn't be public if the return type is not public.

See gh-45521

Signed-off-by: Yanming Zhou <[email protected]>
snicoll added a commit that referenced this pull request May 13, 2025
* pr/45521:
  Polish MetricsAutoConfiguration

Closes gh-45521
@snicoll
Copy link
Member

snicoll commented May 13, 2025

Closed by c25e330

@snicoll snicoll closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants