-
Notifications
You must be signed in to change notification settings - Fork 136
Documentation: add "Extensions to SQL" page #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix sqlpage#877 Co-authored-by: Ophir LOJKINE <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much !
I made a few suggestions, feel free to accept or reject them, then I'll merge :)
examples/official-site/your-first-sql-website/extensions-to-sql.md
Outdated
Show resolved
Hide resolved
examples/official-site/your-first-sql-website/extensions-to-sql.md
Outdated
Show resolved
Hide resolved
examples/official-site/your-first-sql-website/extensions-to-sql.md
Outdated
Show resolved
Hide resolved
examples/official-site/your-first-sql-website/extensions-to-sql.md
Outdated
Show resolved
Hide resolved
examples/official-site/your-first-sql-website/extensions-to-sql.md
Outdated
Show resolved
Hide resolved
2b1cf1f
to
bf0336c
Compare
Great additions, I learned new stuff, again :) What do you think about moving the page to the website's root directory? |
Yes, I'm ok with moving to the root! |
bf0336c
to
cd509b2
Compare
Done :D |
Thank you very much! |
Just found out about the Should it be added as well, or is it plain SQL? I don't know anymore 😅 |
The If you want to learn more about sqlpage internals, this ai-generated wiki is quite helpful: https://deepwiki.com/sqlpage/SQLPage |
Ok, I wondered because I saw this syntax in the following example, which is flagged as SQLite on the website. https://github.com/sqlpage/SQLPage/blob/main/examples/corporate-conundrum/wait.sql |
We have a special compatibility tweak, but it comes with a warning: https://github.com/sqlpage/SQLPage/blob/main/src/webserver/database/sql.rs#L910-L917 |
The sqlite examples that rely on it should be updated |
According to discussion here sqlpage#897 (comment)
According to discussion here #897 (comment) Co-authored-by: ppom <>
Closes #877
I'm quite happy with this addition! I hope it'll save some time to newcomers.
However, I'm not convinced that the page belongs in 'Your first SQL website' directory.
Would you agree to move it up?
Documenting already took quite some time, and I don't have much energy to update this PR if you have suggestions.
So don't hesitate to rephrase and rework things if you don't like them!