feat: Add standard client headers #1130
Conversation
Pull Request Test Coverage Report for Build 14792480636Details
💛 - Coveralls |
grdsdev
changed the title
|
|
||
| class Constants { | ||
| static const Map<String, String> defaultHeaders = { | ||
| static String get platform { | ||
| return Platform.operatingSystem; |
There was a problem hiding this comment.
I know this is still draft, but still want to mention that this won't work on web.
You will either need a conditional import, or probably better use a constant to guard web with a definition like the kIsWeb in flutter:
const bool kIsWeb = bool.fromEnvironment('dart.library.js_util');There was a problem hiding this comment.
Thanks, @Vinzent03
Do we have any test for asserting that it doesn't break in Web? Didn't see any fail on CI.
There was a problem hiding this comment.
Sadly not yet, but hopefully #1140 solves this
There was a problem hiding this comment.
@Vinzent03 I added the guard as you suggested, we could send data in case of web, if that is easy to do, not a requirement since our reports also fetches from the user-agent, and user-agent in web is better defined then mobile.
grdsdev
force-pushed
the
guilherme/clibs-120-supabase-flutter-send-standard-client-headers-on-all
branch
from
3e7b4aa to
070966e
Compare
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.