Skip to content

[AST] Temporarily turn off an assert on empty scopeLifetimeParamIndices #81117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Apr 26, 2025

scopeLifetimeParamIndices sometimes ends up non-null but empty, which triggers an assert module deserialization, blocking cross-module work on nonescapable types.

This appears to be the same underlying issue as the inheritLifetimeParamIndices assert we caught during Optional/Result's generalization, but on a different input argument.

It seems reasonable to mitigate this problem the same way.

rdar://147765187

`scopeLifetimeParamIndices` sometimes ends up non-null but empty, which causes crashes in module deserialization, blocking cross-module work on nonescapable types.

rdar://147765187
@lorentey lorentey requested a review from atrick April 26, 2025 01:42
@lorentey
Copy link
Member Author

@swift-ci smoke test

@lorentey
Copy link
Member Author

@swift-ci build toolchain

@lorentey lorentey merged commit f69997e into swiftlang:main Apr 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant