[Sema] Support additional args in @dynamicMemberLookup subscripts #81148
+1,002
−321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiferber
commented
Apr 28, 2025
| /// a default value | ||
| /// | ||
| /// Subscripts which don't meet these requirements strictly are not eligible. | ||
| enum class DynamicMemberLookupSubscriptEligibility : uint8_t { |
There was a problem hiding this comment.
DynamicMemberLookupSubscriptEligibility is... a mouthful — but it's the least-inaccurate name I could come up with. Happy to improve this with suggestions!
itaiferber
commented
Apr 28, 2025
Comment on lines
+7578
to
+7579
| DynamicMemberLookupSubscriptEligibility | ||
| getDynamicMemberLookupSubscriptEligibility(); |
There was a problem hiding this comment.
Instead of exposing this enum, I suppose it is also possible to restore isValidDynamicMemberLookupSubscript() et. al., but I do think it's nicer to have a type-safe interface that's harder to typo.
itaiferber
commented
Apr 28, 2025
itaiferber
commented
Apr 28, 2025
|
@swift-ci please smoke test |
`SubscriptDecl`s may get checked multiple times for eligibility in fulfilling `@dynamicMemberLookup` requirements; since the checks are non-trivial and the result doesn't change, this eligibility can be cached in the decl's `Bits`.
`SubscriptDecl` exposes eligibility for `@dynamicMemberLookup` requirements directly, so the `TypeChecker` interface for these members can be replaced.
Adds support for `SubscriptDecl`s to fulfill `@dynamicMemberLookup` requirements if they have additional arguments after `dynamicMember:` so long as those arguments have default values, or are variadic. This allows exposing values like `#function`, `#fileID`, `#line`, etc. to dynamic member lookup.
Subscripts with `isolated` arguments currently do not pass a compiler assertion about the consistency of the function type w.r.t. isolation. This is because the `ExtInfo` for `SubscriptDecl`s doesn't currently have isolation information applied (though this works in practice); annotating the `ExtInfo` with isolation allows this assertion to pass.
itaiferber
force-pushed
the
additional-dynamicmemberlookup-args
branch
from
725aeab to
5e77bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for satisfying
@dynamicMemberLookuprequirements using subscripts which have arguments followingdynamicMember:so long as they are either variadic or have default arguments. This allows transforming member references intox[dynamicMember:...]calls which can pass in arguments such as#function,#fileID,#line, etc.@dynamicMemberLookupSubscripts swift-evolution#2814Main changes:
SubscriptDecls to satisfy@dynamicMemberLookuprequirements as long asdynamicMember:remains the first explicitly-labeled argument, and all following arguments are eitherisDefaultArgument()orisVariadic()SubscriptDecl.Bits; this was being checked multiple times per decl and it seems prudent to just store the info since we have the bitsExprRewriterto produceArgumentLists for these subscripts by filling inDefaultArgumentExprs as neededThe PR has been split into individual commits for (ideally) ease of review.