-
Notifications
You must be signed in to change notification settings - Fork 10
テストコード例をわかりやすくする #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
コード例に含めたいものとして、下記を意識しています。
意識して今回入れなかったもの:
|
別のPRに依存させてしまいましたが、内容的には独立できるはずなのに手順的にうっかりしました。 |
Pythonらしい良いテストコードだと思います 👍
気になったので、これを意識して今回入れなかった理由があれば教えて下さい 🙏 |
根拠はないのですが、
と考えました。 |
ありがとうございます 🙇♂️ #2 以降マージして良いかなと思うのですがどうでしょう? |
あ、私はマージ権限ないので、どなたかお願いします。念のため |
masterに対して #6 で作り直しました。こちらはクローズします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytestの最新バージョンで使える、わかりやすいパラメタ化テストやフィクスチャの書き方でテストコード例をわかりやすくする。
先行するPR #2 #3 #4 に依存しています。